Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky test TestW3CSpanTraceResourceExtraction #9257

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Disable flaky test TestW3CSpanTraceResourceExtraction #9257

merged 2 commits into from
Apr 13, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax requested a review from a team April 13, 2022 16:34
@dmitryax dmitryax requested a review from anuraaga as a code owner April 13, 2022 16:34
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 13, 2022
@dmitryax
Copy link
Member Author

@pmm-sumo PTAL

@dmitryax dmitryax force-pushed the fix-flaky-test-awsxrayexporter branch from e4e7339 to 5a8b7dd Compare April 13, 2022 16:44
@jpkrohling
Copy link
Member

Linting is still failing:

Error: awsxray_test.go:121:29: undeclared name: `ptrace` (typecheck)
func constructW3CSpanData() ptrace.Traces {

@tigrannajaryan tigrannajaryan mentioned this pull request Apr 13, 2022
Merged
@dmitryax
Copy link
Member Author

@open-telemetry/collector-contrib-maintainer can you please help to merge this?

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Apr 13, 2022
@jpkrohling jpkrohling merged commit b7bf111 into open-telemetry:main Apr 13, 2022
@djaglowski djaglowski mentioned this pull request Apr 13, 2022
Merged
@dmitryax dmitryax deleted the fix-flaky-test-awsxrayexporter branch April 13, 2022 21:06
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

Assignees

@pmm-sumo pmm-sumo

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitryax @jpkrohling @tigrannajaryan @pmm-sumo