[prometheusreceiver] Handle staleNaN for up metric
#9253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noooooope, closing this because NaN is never exposed via I have another idea as to what might cause #5249, will investigate that. |
gouthamve
force-pushed
the
fix-up-nan-scraping
branch
from
e32d073
to
c4d71d8
Compare
|
DONOT MERGE: Depends on prometheus/prometheus#10588 being merged. But once the above PR is merged, we will see the error in #5249 whenever a target goes away (I've verified it). I've fixed it here and will make the PR ready once upstream PR is merged. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
When a target disappears, a StaleNaN is added. We should handle that case too. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
fix-up-nan-scraping
branch
from
c4d71d8
to
4d4efa9
Compare
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
dashpole
added
comp:prometheus
codeboten
approved these changes
May 4, 2022
codeboten
added
the
ready to merge
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…9253) * [prometheusreceiver] Handle staleNaN for up metric When a target disappears, a StaleNaN is added. We should handle that case too. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5249
TODO: