-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/lokiexporter] Fix lokiexporter example config #9066
[exporter/lokiexporter] Fix lokiexporter example config #9066
Conversation
@@ -16,7 +16,6 @@ processors: | |||
# information, see | |||
# https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/memorylimiterprocessor/README.md | |||
memory_limiter: | |||
ballast_size_mib: 683 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deprecated parameter was also preventing the otel container to execute, please let me know if there is a better option than removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recommendation is to use the ballast extension
8c9f176
to
fd92340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, see my response to your question
@@ -16,7 +16,6 @@ processors: | |||
# information, see | |||
# https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/memorylimiterprocessor/README.md | |||
memory_limiter: | |||
ballast_size_mib: 683 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recommendation is to use the ballast extension
The base example otel-collector-config.yml file for the lokiexporter sets resources (plural form) while the mapstructure is resource (singular form).
This PR fixes the sample adjusting it to the actual resource format. Another option would be to make the mapstructure plural, but that would imply a contract (breaking) change.