[receiver/podman] Add timeout config option #9014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a timeout configuration option for the Podman API requests. This can be helpful in cases where the provided endpoint is up but not responding (slow performance, not related endpoint, etc).
It removes the "ping" method call when creating the
newPodmanClientto decouple the API availability with the client's constructor. Indeed, if the endpoint does not include the "/_ping" endpoint the client gets stuck waiting for a response.Link to tracking Issue: #9013
Testing: File added for timeout tests:
podman_client_test.goDocumentation: Updated README.md