[processor/transform] Move function handling logic to common and generify transform context. #8972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-contrib into generify-transform
anuraaga
commented
Mar 30, 2022
| ) | ||
|
|
||
| var registry = map[string]interface{}{ | ||
| "keep_keys": keepKeys, | ||
| "set": set, | ||
| } | ||
|
|
||
| type PathExpressionParser func(*Path) (GetSetter, error) |
There was a problem hiding this comment.
The only real change in this PR besides moving around is the introduction of this type, which parses a path expression in a data-model specific way. The signal processor passes in the expression parser which allows the rest of the logic to apply generically.
Aneurysm9
reviewed
Apr 5, 2022
anuraaga
commented
Apr 5, 2022
Aneurysm9
approved these changes
Apr 6, 2022
Aneurysm9
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This moves logic for function processing into common to allow to work for any signal. The transformation context is generified into including an
interface{}item which is cast to Span only during handling of the trace data model. Someday this will probably be a Go generic.Link to tracking Issue: #8252
Testing: Unit
Documentation: None