[processor/cumulativetodelta] Add include/exclude configuration #8952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
reviewed
Mar 29, 2022
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
|
@Aneurysm9 it appears the link job is hung, can you re-trigger it? |
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
|
PR updated to address the v0.48.0 release. |
|
@open-telemetry/collector-contrib-approvers please review. |
mx-psi
reviewed
Apr 13, 2022
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
reviewed
Apr 13, 2022
mx-psi
reviewed
Apr 13, 2022
There are some tests in processor_test.go that verify that regexp is useable, but I can also add a test to config_test.go |
mx-psi
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Yes, I meant on config_test.go :). This LGTM, but I will wait for any comments by @Aneurysm9 before marking as ready to merge
|
@Aneurysm9 please review |
pmm-sumo
approved these changes
Apr 19, 2022
|
I will wait a couple more days for Anthony and mark as ready to merge then (ping me if I forget) |
mx-psi
added
the
ready to merge
codeboten
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces the existing
metricsconfiguration option in favor of a more robustinclude/excludesystem. The new configuration allows users to specify, either by name or by regex pattern, which metrics should or should not be converted. If neither include or exclude are supplied, all metrics appropriate metrics will be converted. If a name matches both an include and exclude rule, exclude will take precedence.To support existing customers, the
metricsconfiguration is still supported. Themetricsconfiguration cannot be used withinclude/exclude. Whenmetricsis used, a warning will be logged during startup.This PR only updates the configuration options used to determine which metrics should be converted. The underlying convert logic has not been changed.
Link to tracking Issue:
Fixes #5877
Testing:
Unit tests were updated/added. Also tested new configuration locally using hostmetrics receiver.
Documentation:
Updated the processor's readme with the new configuration and more examples. Also clarified that non-monotinic sums are never converted.