[receiver/hostmetrics] Migrate Processes scraper to the Metrics builder #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
migrate-processesscraper
branch
from
4128f12
to
0617437
Compare
dmitryax
force-pushed
the
migrate-processesscraper
branch
3 times, most recently
from
221898f
to
0fc275a
Compare
djaglowski
approved these changes
Mar 28, 2022
dashpole
reviewed
Mar 28, 2022
...tmetricsreceiver/internal/scraper/processesscraper/internal/metadata/generated_metrics_v2.go
Show resolved
Hide resolved
dashpole
approved these changes
Mar 28, 2022
dmitryax
added
the
ready to merge
|
Looks like there's a conflict now. |
dmitryax
force-pushed
the
migrate-processesscraper
branch
from
f55d6a3
to
dc61e09
Compare
|
@jpkrohling , rebased |
codeboten
approved these changes
Mar 30, 2022
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
migrate-processesscraper
branch
from
dc61e09
to
8e9b95c
Compare
|
I just rebased and moved the changelog entry to unreleased. This is ready to be merged. |
|
@codeboten @jpkrohling can you please help with merging this? |
codeboten
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates the last hostmetrics receiver scraper to the new Metrics builder.
This also now allows more the scraper configurations currently provided by the metrics builder:
Closes: #7140