[reciever/*log] Revert syslog-go dependency update. #8545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent update introduced an incompatibility with 386 architecture. This bump also picks up a fix for gonum on Go 1.18.
mx-psi
requested changes
Mar 17, 2022
There was a problem hiding this comment.
We still require go-syslog v3.1.0:
opentelemetry-collector-contrib/go.mod
Line 327 in 200b69d
So I still get the build error locally:
❯ GOOS=linux GOARCH=386 make otelcontribcol
GO111MODULE=on CGO_ENABLED=0 go build -trimpath -o ./bin/otelcontribcol_linux_386 \
-ldflags "-X github.com/open-telemetry/opentelemetry-collector-contrib/internal/version.Version=v0.47.0-4-g200b69dd7" -tags "" ./cmd/otelcontribcol
go: downloading github.com/aws/aws-sdk-go v1.43.20
go: downloading github.com/influxdata/influxdb-observability/common v0.2.16
go: downloading github.com/influxdata/influxdb-observability/otel2influx v0.2.16
go: downloading github.com/open-telemetry/opentelemetry-log-collection v0.27.2
go: downloading github.com/influxdata/influxdb-observability/influx2otel v0.2.16
go: downloading gonum.org/v1/gonum v0.11.0
# github.com/observiq/go-syslog/v3/rfc5424
../../../go/pkg/mod/github.com/observiq/go-syslog/v3@v3.1.0/rfc5424/machine.go:115:7: constant 4294967295 overflows int
|
@mx-psi Please try again |
bogdandrutu
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent update introduced an incompatibility with 386 architecture.
Context: open-telemetry/opentelemetry-collector#5013 (comment)