Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Deprecate config.Config.OnceMetadata method #8359

Merged
merged 6 commits into from
Mar 21, 2022
Merged

[exporter/datadog] Deprecate config.Config.OnceMetadata method #8359

merged 6 commits into from
Mar 21, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 9, 2022 •
edited
Loading

Description:

Deprecate OnceMetadata method from Config struct. This method was only here because the configuration is in a different package.

External users can't really leverage this for anything useful, but I am trying to follow the guidelines and deprecate it in two steps.

Link to tracking Issue: #8373

Testing:

  • Amended unit tests.
  • End to end test when sending metrics and traces with only_metadata set to true and to false

@mx-psi mx-psi marked this pull request as ready for review March 10, 2022 11:32
@mx-psi mx-psi requested review from a team and anuraaga March 10, 2022 11:32
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Mar 21, 2022
jpkrohling
jpkrohling reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving by proxy, as the author is a code owner and has received approval from another code owner.

@jpkrohling jpkrohling merged commit 85d7ca2 into open-telemetry:main Mar 21, 2022
@mx-psi mx-psi deleted the mx-psi/sync-once branch March 21, 2022 12:20
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@KSerrania KSerrania KSerrania approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

Assignees

@djaglowski djaglowski

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mx-psi @jpkrohling @KSerrania @djaglowski