[receiver/mongodbatlas] fix attribute key on disk partition metrics (#…

…7747)
open-telemetry · Mar 9, 2022 · 5cd8dd9 · 5cd8dd9
1 parent 488e701
commit 5cd8dd9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,8 @@
 
 ### 🛑 Breaking changes 🛑
 
+- `mongodbatlasreceiver`: rename mislabeled attribute `memory_state` to correct `disk_status` on partition disk metrics (#7747)
+
 ### 🧰 Bug fixes 🧰
 
 - `zipkinexporter`: Set "error" tag value when status is set to error (#8187)

diff --git a/receiver/mongodbatlasreceiver/documentation.md b/receiver/mongodbatlasreceiver/documentation.md
@@ -14,8 +14,8 @@ These are the metrics available for this scraper.
 | **mongodbatlas.disk.partition.iops.max** | Disk partition iops Aggregate of MongoDB Metrics MAX_DISK_PARTITION_IOPS_WRITE, MAX_DISK_PARTITION_IOPS_TOTAL, MAX_DISK_PARTITION_IOPS_READ | {ops}/s | Gauge(Double) | <ul> <li>disk_direction</li> </ul> |
 | **mongodbatlas.disk.partition.latency.average** | Disk partition latency Aggregate of MongoDB Metrics DISK_PARTITION_LATENCY_WRITE, DISK_PARTITION_LATENCY_READ | ms | Gauge(Double) | <ul> <li>disk_direction</li> </ul> |
 | **mongodbatlas.disk.partition.latency.max** | Disk partition latency Aggregate of MongoDB Metrics MAX_DISK_PARTITION_LATENCY_WRITE, MAX_DISK_PARTITION_LATENCY_READ | ms | Gauge(Double) | <ul> <li>disk_direction</li> </ul> |
-| **mongodbatlas.disk.partition.space.average** | Disk partition space Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_FREE, DISK_PARTITION_SPACE_USED | By | Gauge(Double) | <ul> <li>memory_state</li> </ul> |
-| **mongodbatlas.disk.partition.space.max** | Disk partition space Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_FREE, DISK_PARTITION_SPACE_USED | By | Gauge(Double) | <ul> <li>memory_state</li> </ul> |
+| **mongodbatlas.disk.partition.space.average** | Disk partition space Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_FREE, DISK_PARTITION_SPACE_USED | By | Gauge(Double) | <ul> <li>disk_status</li> </ul> |
+| **mongodbatlas.disk.partition.space.max** | Disk partition space Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_FREE, DISK_PARTITION_SPACE_USED | By | Gauge(Double) | <ul> <li>disk_status</li> </ul> |
 | **mongodbatlas.disk.partition.usage.average** | Disk partition usage (%) Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_PERCENT_FREE, DISK_PARTITION_SPACE_PERCENT_USED | 1 | Gauge(Double) | <ul> <li>disk_status</li> </ul> |
 | **mongodbatlas.disk.partition.usage.max** | Disk partition usage (%) Aggregate of MongoDB Metrics MAX_DISK_PARTITION_SPACE_PERCENT_USED, MAX_DISK_PARTITION_SPACE_PERCENT_FREE | 1 | Gauge(Double) | <ul> <li>disk_status</li> </ul> |
 | **mongodbatlas.disk.partition.utilization.average** | Disk partition utilization (%) MongoDB Metrics DISK_PARTITION_UTILIZATION | 1 | Gauge(Double) | <ul> </ul> |

diff --git a/receiver/mongodbatlasreceiver/internal/metadata/metric_name_mapping.go b/receiver/mongodbatlasreceiver/internal/metadata/metric_name_mapping.go
@@ -608,19 +608,19 @@ var metricNameMapping = map[string]metricMappingData{
 
 	// Measures latency per operation type of the disk partition used by MongoDB.
 	"DISK_PARTITION_SPACE_FREE": {"mongodbatlas.disk.partition.space.average", map[string]pdata.AttributeValue{
-		"memory_state": pdata.NewAttributeValueString("free"),
+		"disk_status": pdata.NewAttributeValueString("free"),
 	}},
 
 	"MAX_DISK_PARTITION_SPACE_FREE": {"mongodbatlas.disk.partition.space.max", map[string]pdata.AttributeValue{
-		"memory_state": pdata.NewAttributeValueString("free"),
+		"disk_status": pdata.NewAttributeValueString("free"),
 	}},
 
 	"DISK_PARTITION_SPACE_USED": {"mongodbatlas.disk.partition.space.average", map[string]pdata.AttributeValue{
-		"memory_state": pdata.NewAttributeValueString("used"),
+		"disk_status": pdata.NewAttributeValueString("used"),
 	}},
 
 	"MAX_DISK_PARTITION_SPACE_USED": {"mongodbatlas.disk.partition.space.max", map[string]pdata.AttributeValue{
-		"memory_state": pdata.NewAttributeValueString("used"),
+		"disk_status": pdata.NewAttributeValueString("used"),
 	}},
 
 	"DISK_PARTITION_SPACE_PERCENT_FREE": {"mongodbatlas.disk.partition.utilization.average", map[string]pdata.AttributeValue{

diff --git a/receiver/mongodbatlasreceiver/metadata.yaml b/receiver/mongodbatlasreceiver/metadata.yaml
@@ -579,15 +579,15 @@ metrics:
     description: Disk partition space
     extended_documentation: Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_FREE, DISK_PARTITION_SPACE_USED
     unit: By
-    attributes: [memory_state]
+    attributes: [disk_status]
     gauge:
       value_type: double
   mongodbatlas.disk.partition.space.average:
     enabled: true
     description: Disk partition space
     extended_documentation: Aggregate of MongoDB Metrics DISK_PARTITION_SPACE_FREE, DISK_PARTITION_SPACE_USED
     unit: By
-    attributes: [memory_state]
+    attributes: [disk_status]
     gauge:
       value_type: double
   mongodbatlas.db.size: