Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

feat: UI adjustments #42

Merged
merged 3 commits into from
May 9, 2023
Merged

feat: UI adjustments #42

merged 3 commits into from
May 9, 2023

Conversation

nightknighto
Copy link
Contributor

@nightknighto nightknighto commented May 9, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Removes gaps between languages
  • Decrease number of repos displayed in user cards from 4 to 3
  • Use user's github login name with it's exact format instead of the incoming username parameter (so now matches letter capitalization as the user has in his github's username)

Related Tickets & Documents

closes #25, closes #22

Mobile & Desktop Screenshots/Recordings

removing gap and decreasing repos count:

image

+ using user's github login name

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@nightknighto nightknighto requested a review from 0-vortex May 9, 2023 19:27
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

We could check some highlight cards against their github image displayed on insights feeds tab to be 100% scientific :D

@nightknighto nightknighto merged commit acbe81a into beta May 9, 2023
@nightknighto nightknighto deleted the ui-adjustments branch May 9, 2023 19:50
github-actions bot pushed a commit that referenced this pull request May 9, 2023
## [2.1.0-beta.6](v2.1.0-beta.5...v2.1.0-beta.6) (2023-05-09)

### πŸ• Features

* UI adjustments ([#42](#42)) ([acbe81a](acbe81a))
@github-actions
Copy link

github-actions bot commented May 9, 2023

πŸŽ‰ This PR is included in version 2.1.0-beta.6 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request May 9, 2023
* feat: remove lang gaps

* feat: decrease user repos limit

* feat: use user's github login name acbe81a
github-actions bot pushed a commit that referenced this pull request May 9, 2023
## [2.1.0](v2.0.1...v2.1.0) (2023-05-09)

### πŸ› Bug Fixes

* Overflowing language bar fix ([#38](#38)) ([3dc1a0a](3dc1a0a))

### πŸ• Features

* adding utilities for cards local generation & testing ([#34](#34)) ([c5a5fec](c5a5fec))
* Highlight Cards UI Generation (frontend-only) ([#36](#36)) ([138a847](138a847))
* highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25))
* higlight card upload & storage ([#39](#39)) ([b6abefa](b6abefa))
* UI adjustments ([#42](#42)) ([acbe81a](acbe81a))
@github-actions
Copy link

github-actions bot commented May 9, 2023

πŸŽ‰ This PR is included in version 2.1.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants