Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full change to chakra-UI #313

Open
3 tasks done
FlorianK13 opened this issue Sep 20, 2024 · 2 comments · May be fixed by #329
Open
3 tasks done

Full change to chakra-UI #313

FlorianK13 opened this issue Sep 20, 2024 · 2 comments · May be fixed by #329
Assignees
@FlorianK13
Labels
low prio This might be done in the future, right now it has low priority

Comments

@FlorianK13
Copy link
Member

FlorianK13 commented Sep 20, 2024 •
edited
Loading

All the .scss files and old code from the old template create warnings when we build the website. We should delete this, get rid of some old dependencies, and fully use chakra UI instead.

  • Remove Burger Menu
  • Scan .scss Files and remove old content
  • Convert Remaining content to good old .css files
@FlorianK13 FlorianK13 added the low prio This might be done in the future, right now it has low priority label Sep 20, 2024
@FlorianK13
Copy link
Member Author

React-helmet-async

One dependency that we have is the react-helmet-async, which is basically the React Helmet. As far as I understand, this adapts the .html files based on whether we show the map, about, or other pages. Probably we keep this dependency.

FlorianK13 added a commit that referenced this issue Sep 26, 2024
@FlorianK13
Delete Hamburger Component #313
0427a1c
FlorianK13 added a commit that referenced this issue Sep 26, 2024
@FlorianK13
Uninstall react-burger-menu #313
061b641
@FlorianK13
Copy link
Member Author

The burger menu was removed. There is now the problem that somewhere in the .scss code lies the functionality that our navigation tab (on the upper side of the screen) disappears for some screen width < threshold value.

FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete _page.scss #313
b31e37f
FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete _hamburger styling #313
e4544dd
FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete unused styling components #313
15eb809
FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete intro styling layout #313
ac4e60c
FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete pageNotFound styling #313
ea06d85
FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete menu styling #313
321a87f
FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete typography styling #313
1decdc0 
This changes some fonts, but does not affect functionality
FlorianK13 added a commit that referenced this issue Sep 30, 2024
@FlorianK13
Delete import-normalize #313
78f7d1b 
This did not show any functionality
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Move content of _main.scss #313
b8d14dd
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Make OpenPV a chackra heading #313
862fbb1
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Change header list to chakra styling #313
f2db8c8
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Delete unused styling from header #313
2b785cb
@FlorianK13 FlorianK13 linked a pull request Oct 3, 2024 that will close this issue
313 delete old dependencies #329
Open
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Change Navigation to chakra component (tabs) #313
7de9751
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Move wrapper content to main.scss #313
a502aaa
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Delete unused wrapper styling functions #313
51f03ee
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Delete unused styling functions #313
95a0418
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Delete main wrapper and last scss dep #313
fdd5532
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Delete sass dependency #313
a3c6de5
FlorianK13 added a commit that referenced this issue Oct 3, 2024
@FlorianK13
Delete reference to old template #313
d405bdb
@FlorianK13 FlorianK13 self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianK13 FlorianK13

Labels
low prio This might be done in the future, right now it has low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

313 delete old dependencies open-pv/website
1 participant
@FlorianK13