Add query parameters to input #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsandall
reviewed
Jun 18, 2018
server/authorizer/authorizer_test.go
Outdated
| "params": query, | ||
| } | ||
|
|
||
| if !reflect.DeepEqual(result, expectedResult) { |
There was a problem hiding this comment.
I think it would be better to compare the input against the AST or JSON representation of the input. As is, it's not easy to tell that the query params are being serialized correctly.
For example:
expected := util.MustUnmarshalJSON([]byte(`
{
"path": ["foo","bar"],
"method": "GET",
"identity": "bob",
"params": {"pretty": ["true"], "explain": ["full"]}
}
`)
if !reflect.DeepEqual(result, expected) { // error }
tsandall
requested changes
Jun 18, 2018
Closes open-policy-agent#781 Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
ashutosh-narkar
force-pushed
the
add-query-params
branch
from
b3eb620
to
dcc5994
Compare
tsandall
approved these changes
Jun 18, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #781
Signed-off-by: Ashutosh Narkar anarkar4387@gmail.com