server: handle foo%2fbar in path (#695) #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Renatus <srenatus@chef.io>
Now, GET /v1/data/foo%2fbar will construct a query string of
data["foo/bar"]
allowing to retrieve the key mentioned in issue open-policy-agent#695.
However, I believe further work would be necessary, as the code path for
POST/PATCH/DELETE is different. (That has also blocked added a test for
this change, unfortunately.)
I also couldn't get this to work with POST /v0/data/foo%2fbar. (But I also
haven't tried very long, to be honest.)
Signed-off-by: Stephan Renatus <srenatus@chef.io>
|
This works for the reads. I will submit a follow up PR that does the same for writes. |
tsandall
added a commit
to tsandall/opa
that referenced
this pull request
Apr 12, 2018
These changes extend open-policy-agent#702 to include writes. If the path segments are escaped, the should be unescaped during parsing. This allows callers to write keys like "foo/bar" into storage. Fixes open-policy-agent#695 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, GET /v1/data/foo%2fbar will construct a query string of
allowing to retrieve the key mentioned in issue #695.
However, I believe further work would be necessary, as the code path for
POST/PATCH/DELETE is different. (That has also blocked added a test for
this change, unfortunately.)
I also couldn't get this to work with POST /v0/data/foo%2fbar. (But I also
haven't tried very long, to be honest.)