Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.send built-in tests fail if google.com can't be reached #945

Closed
tsandall opened this issue Sep 14, 2018 · 0 comments
Closed

http.send built-in tests fail if google.com can't be reached #945

tsandall opened this issue Sep 14, 2018 · 0 comments
Assignees
@ashutosh-narkar
Labels
bug

Comments

@tsandall
Copy link
Member

The http.send built-in calls that hit google.com fail if google.com can't be reached or if you're simply not connected to the internet. Given a working copy of OPA, it should be possible to build and test without an internet connection.

To workaround this, perhaps we can run a test HTTP server that sends a redirect.
@tsandall tsandall added the bug label Sep 14, 2018
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Sep 14, 2018
@ashutosh-narkar
Update http.send test to work w/o internet access
b923304 
Fixes open-policy-agent#945

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar ashutosh-narkar mentioned this issue Sep 14, 2018
Merged
tsandall pushed a commit that referenced this issue Sep 14, 2018
@ashutosh-narkar @tsandall
Update http.send test to work w/o internet access
c81d653 
Fixes #945

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashutosh-narkar ashutosh-narkar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsandall @ashutosh-narkar