Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client certificates for service authentication #684

Closed
tsandall opened this issue Apr 2, 2018 · 0 comments
Closed

Support client certificates for service authentication #684

tsandall opened this issue Apr 2, 2018 · 0 comments

Comments

@tsandall
Copy link
Member

tsandall commented Apr 2, 2018

Currently the service client used for bundle downloading, status reporting, and decision log uploading only supports bearer tokens for authentication. Some users would prefer to rely on client certificates.

The credentials configuration could be extended to include a "client_tls" key:

credentials:
  client_tls:
    cert: /path/to/cert
    private_key: /path/to/key
    private_key_passphrase: 1234

Service clients are instantiated from configuration here. To implement this enhancement, we need to extend the client configuration defined earlier in that file with the client TLS parameters defined above. The validation step should load and parse files from disk (returning errors if necessary). In addition, the HTTP client used internally will need to configured with the TLS certificates.

kichristensen added a commit to kichristensen/opa that referenced this issue Oct 22, 2018
Adds support for usings client certificates to authenticate against
service endpoints. It also enables users to allow insecure TLS
connections to service endpoints.

Fixes open-policy-agent#684

Signed-off-by: Kim Christensen <kimworking@gmail.com>
tsandall pushed a commit that referenced this issue Oct 25, 2018
Adds support for usings client certificates to authenticate against
service endpoints. It also enables users to allow insecure TLS
connections to service endpoints.

Fixes #684

Signed-off-by: Kim Christensen <kimworking@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant