Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial eval: call expression not saved when unknown is embedded inside composite #621

Closed
tsandall opened this issue Feb 19, 2018 · 0 comments
Closed

partial eval: call expression not saved when unknown is embedded inside composite #621

tsandall opened this issue Feb 19, 2018 · 0 comments
Labels
bug

Comments

@tsandall
Copy link
Member

Call expressions are not being saved when an input contains an unknown value embedded inside of an array, object, set, etc.

> sum([input]) = x
sum([input]): eval_type_error: sum: operand 1 must be array of numbers but got array containing var
@tsandall tsandall added the bug label Feb 19, 2018
@tsandall tsandall added this to the v0.8 milestone Mar 5, 2018
tsandall added a commit to tsandall/opa that referenced this issue Mar 6, 2018
@tsandall
Update partial eval to check call args recursively
c66bcd3 
Previously, partial eval was not checking call args recursively for
terms in the save set. As a result, if a call expression passed a term
that had an unknown embedded, the call would be evaluated, which could
potentially result in an internal error.

Fixes open-policy-agent#621
@tsandall tsandall mentioned this issue Mar 6, 2018
Merged
tsandall added a commit that referenced this issue Mar 6, 2018
@tsandall
Update partial eval to check call args recursively
505b8fa 
Previously, partial eval was not checking call args recursively for
terms in the save set. As a result, if a call expression passed a term
that had an unknown embedded, the call would be evaluated, which could
potentially result in an internal error.

Fixes #621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsandall