Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken submission form row styling #4715

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen commented Sep 30, 2024

Closes #4711

Changes

Changed the .form-row styling to be more specific.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (7b20acc) to head (531bb8b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4715   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         746      746           
  Lines       25174    25174           
  Branches     3310     3310           
=======================================
  Hits        24309    24309           
  Misses        601      601           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Oct 2, 2024
@sergei-maertens sergei-maertens changed the title issue/4711-form-row-styling Fix broken submission form row styling Oct 2, 2024
@sergei-maertens sergei-maertens merged commit 1a67d2a into master Oct 2, 2024
34 checks passed
@sergei-maertens sergei-maertens deleted the issue/4711-form-row-styling branch October 2, 2024 07:36
sergei-maertens pushed a commit that referenced this pull request Oct 2, 2024
sergei-maertens pushed a commit that referenced this pull request Oct 2, 2024
@sergei-maertens
Copy link
Member

sergei-maertens commented Oct 2, 2024

Backports:

sergei-maertens pushed a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submissions admin view quirks
2 participants