Skip to content

Commit

Permalink
fixup: spelling, minor non-normative clarifications
Browse files Browse the repository at this point in the history
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
  • Loading branch information
toddbaert committed May 8, 2023
1 parent b3e0c8c commit db43992
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions specification/sections/01-flag-evaluation.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ See [provider initialization](./02-providers.md#24-initialization).

> The `provider mutator` function **MUST** invoke the `shutdown` function on the previously registered provider once it's no longer being used to resolve flag values.
Setting a new provider means the previous provider is no longer in use, and should therefor be disposed of using it's `shutdown` function.
Setting a new provider means the previous provider is no longer in use, and should therefore be disposed of using it's `shutdown` function.

see: [shutdown](./02-providers.md#26-shutdown), [setting a provider](#setting-a-provider)

Expand Down Expand Up @@ -266,7 +266,7 @@ See [hooks](./04-hooks.md) for details.

> The API **MUST** define a `shutdown` function, which, when called, must call the respective `shutdown` function on the active provider.
The precise name of this function is not prescribed by this specification.
The precise name of this function is not prescribed by this specification, but should be defined be the SDK.
Relevant language idioms should be considered when choosing the name for this function, in accordance with the resource-disposal semantics of the language in question.

see: [`shutdown`](./02-providers.md#25-shutdown)
2 changes: 1 addition & 1 deletion specification/sections/02-providers.md
Original file line number Diff line number Diff line change
Expand Up @@ -250,5 +250,5 @@ class MyProvider implements Provider, AutoDisposable {

Providers may maintain remote connections, timers, threads or other constructs that need to be appropriately disposed of.
Provider authors may implement the `shutdown` function to perform relevant clean-up actions.
The precise name of this function is not prescribed by this specification.
The precise name of this function is not prescribed by this specification, but should be defined be the SDK.
Relevant language idioms should be considered when choosing the name for this function, in accordance with the resource-disposal semantics of the language in question.

0 comments on commit db43992

Please sign in to comment.