Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OpenFeature::FlagD::Provider::Configuration #14

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

alxckn
Copy link
Contributor

@alxckn alxckn commented Apr 6, 2024

This PR

  • Refactor Configuration so the #merge methods behaves in a similar manner as ruby Hash#merge
  • Parse port as integer

Related Issues

Follow up from #13

How to test

rspec

Signed-off-by: Alexandre Chakroun <alexandre.chakroun@doctolib.com>
@alxckn alxckn changed the title Refactor OpenFeature::FlagD::Provider::Configuration refactor: OpenFeature::FlagD::Provider::Configuration Apr 6, 2024
@beeme1mr beeme1mr closed this Apr 8, 2024
@beeme1mr beeme1mr reopened this Apr 8, 2024
@beeme1mr beeme1mr merged commit 3686eb5 into open-feature:main Apr 8, 2024
4 checks passed
maxveldink pushed a commit that referenced this pull request Apr 8, 2024
Signed-off-by: Alexandre Chakroun <alexandre.chakroun@doctolib.com>
Signed-off-by: Max VelDink <mveldink@justworks.com>
beeme1mr pushed a commit that referenced this pull request May 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](openfeature-flagd-provider-v0.0.1...openfeature-flagd-provider/v0.1.0)
(2024-05-16)


### ⚠ BREAKING CHANGES

* update flagd name and grpc schema
([#30](#30))

### ✨ New Features

* Add flagd provider
([#2](#2))
([98b695b](98b695b))
* Add support for unix socket path and secure connection
([#8](#8))
([88436c7](88436c7))
* Flagd provider uses structs from sdk
([#24](#24))
([d437e7f](d437e7f))
* integrate flagd provider with OpenFeature SDK
([#18](#18))
([80d6d02](80d6d02))
* Return default value on error
([#25](#25))
([f365c6d](f365c6d))
* update flagd name and grpc schema
([#30](#30))
([ddd438a](ddd438a))


### 🧹 Chore

* Format with standard
([#20](#20))
([bf25043](bf25043))
* Make things work
([#13](#13))
([5968037](5968037))
* update link to use new doc domain
([#12](#12))
([9baff65](9baff65))
* upgrade grpc client
([#16](#16))
([23ed78a](23ed78a))


### 🔄 Refactoring

* OpenFeature::FlagD::Provider::Configuration
([#14](#14))
([3686eb5](3686eb5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants