-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secure connection support for FlagD provider #5
Comments
@toddbaert I was looking at the grpc code and there seems to be several options for secure connection: See the following: I noticed in the js implementation there is a helper for creating a secure connection: https://github.com/open-feature/js-sdk-contrib/blob/main/libs/providers/flagd/src/lib/service/grpc/service.ts#L37 I'm confused which we would opt for in the ruby version |
I'll try to wrap my head around this and consider it when I review your PR. |
@toddbaert I think I figured it out, one of the things that's interesting is that the js implementation doesn't seem to reference any root cert but you are just calling the |
@toddbaert is you see the ruby implementation, I create a ChannelCredentials that takes in three arguments; the root cert, the client pem and client .key. Looking at the tests for the secure credentials, it seems we only really need the root cert. https://github.com/open-feature/ruby-sdk-contrib/pull/8/files#diff-107800d1f2e81e1a1cee625510ebc053f2d8e366b44610db6a7b8078807fcd0cR83-R85 |
What?
This issue is to track what it would take to add secure connection to the flagd provider
Reference 📜
https://github.com/open-feature/ruby-sdk-contrib/pull/2/files#r1061691267
The text was updated successfully, but these errors were encountered: