Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Use same type for flag metadata and event metadata #241

Merged
merged 3 commits into from
Apr 23, 2024
Merged

feat!: Use same type for flag metadata and event metadata #241

merged 3 commits into from
Apr 23, 2024

Commits on Apr 22, 2024

  1. feat!: Use same type for flag metadata and event metadata 

    The spec describes two types(flag metadata, and event metadata) that are functionally the same. This PR
makes a breaking change to bring both of the types to use a generic ImmutableMetadata type.

- Rename BaseMetadata to Immutable, make sealed class and implement a empty constructor

Fixes: #234

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
    @benjiro @toddbaert
    benjiro authored and toddbaert committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a016f66 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/use-consistent-metadata-types

    @toddbaert
    toddbaert committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    be8ab7e View commit details
    Browse the repository at this point in the history

  3. fixup: format 

    Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
    @toddbaert
    toddbaert committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0845fb6 View commit details
    Browse the repository at this point in the history