Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove reference to NETFramework.ReferenceAssemblies #219

Closed
wants to merge 1 commit into from

Conversation

benjiro
Copy link
Member

@benjiro benjiro commented Jan 27, 2024

This PR

Since turning on CPM the code coverage build has broken, see here

Believe we don't need to reference this anymore as its being implicitly included

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a7e98d) 93.50% compared to head (57d60f6) 93.50%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          23       23           
  Lines         954      954           
  Branches      105      105           
=======================================
  Hits          892      892           
  Misses         38       38           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjiro benjiro closed this Jan 27, 2024
@austindrenski
Copy link
Member

@benjiro I'm not sure why dotnet test is reporting an error when including the reference assemblies in that report workflow.

AFAIK those reference assemblies don't come for free with the .NET SDK on Linux, which is why we have to include them manually. I know that was at least true in the past, so I guess it might have changed, but idk...

Any chance it's something about codecover being included?

@austindrenski
Copy link
Member

Wait scratch that, looks like this workflow might just have gotten messed up?

It looks like it's referencing a matrix variable without defining the strategy matrix:

Screenshot_20240127-144009.png

austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this pull request Jan 27, 2024
See: open-feature#219

Signed-off-by: Austin Drenski <austin@austindrenski.io>
@austindrenski
Copy link
Member

austindrenski commented Jan 27, 2024

Going to try addressing this as part of #196 which is already cleaning up some other matrices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants