Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses the same import path for instructor_task.models as edxapp #128

Merged
merged 1 commit into from
Nov 8, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
- "pip install -r requirements.txt"
- "pip install -r $VIRTUAL_ENV/src/xblock-sdk/requirements/base.txt"
- "pip install -r $VIRTUAL_ENV/src/xblock-sdk/requirements/test.txt"
- "pip uninstall -y xblock-problem-builder && python setup.py sdist && pip install dist/xblock-problem-builder-2.6.0.tar.gz"
- "pip uninstall -y xblock-problem-builder && python setup.py sdist && pip install dist/xblock-problem-builder-2.6.1.tar.gz"
- "pip install -r test_requirements.txt"
- "mkdir var"
test:
Expand Down
2 changes: 1 addition & 1 deletion problem_builder/instructor_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def download_url_for_last_report(self):
# Unfortunately this is a bit inefficient due to the ReportStore API
if not self.last_export_result or self.last_export_result['error'] is not None:
return None
from instructor_task.models import ReportStore
from lms.djangoapps.instructor_task.models import ReportStore
report_store = ReportStore.from_config(config_name='GRADES_DOWNLOAD')
course_key = getattr(self.scope_ids.usage_id, 'course_key', None)
return dict(report_store.links_for(course_key)).get(self.last_export_result['report_filename'])
Expand Down
2 changes: 1 addition & 1 deletion problem_builder/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from celery.task import task
from celery.utils.log import get_task_logger
from instructor_task.models import ReportStore
from lms.djangoapps.instructor_task.models import ReportStore
from opaque_keys.edx.keys import CourseKey
from student.models import user_by_anonymous_id
from xmodule.modulestore.django import modulestore
Expand Down
48 changes: 32 additions & 16 deletions problem_builder/tests/integration/test_instructor_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ def test_students_dont_see_interface(self):

@patch.dict('sys.modules', {
'problem_builder.tasks': MockTasksModule(successful=True),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_export_field_container_width(self):
Expand All @@ -79,8 +81,10 @@ def test_export_field_container_width(self):

@patch.dict('sys.modules', {
'problem_builder.tasks': MockTasksModule(successful=True),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_root_block_select_width(self):
Expand All @@ -96,8 +100,10 @@ def test_root_block_select_width(self):

@patch.dict('sys.modules', {
'problem_builder.tasks': MockTasksModule(successful=True),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_data_export_delete(self):
Expand Down Expand Up @@ -126,8 +132,10 @@ def test_data_export_delete(self):

@patch.dict('sys.modules', {
'problem_builder.tasks': MockTasksModule(successful=True),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_data_export_success(self):
Expand Down Expand Up @@ -164,8 +172,10 @@ def test_data_export_success(self):

@patch.dict('sys.modules', {
'problem_builder.tasks': MockTasksModule(successful=False),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_data_export_error(self):
Expand Down Expand Up @@ -196,8 +206,10 @@ def test_data_export_error(self):

@patch.dict('sys.modules', {
'problem_builder.tasks': MockTasksModule(successful=True),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_pagination_no_results(self):
Expand Down Expand Up @@ -230,8 +242,10 @@ def test_pagination_no_results(self):
'Test section', 'Test subsection', 'Test unit',
'Test type', 'Test question', 'Test answer', 'Test username'
]]),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_pagination_single_result(self):
Expand Down Expand Up @@ -270,8 +284,10 @@ def test_pagination_single_result(self):
'Test section', 'Test subsection', 'Test unit',
'Test type', 'Test question', 'Test answer', 'Test username'
] for _ in range(PAGE_SIZE*3)]),
'instructor_task': True,
'instructor_task.models': MockInstructorTaskModelsModule(),
'lms': True,
'lms.djangoapps': True,
'lms.djangoapps.instructor_task': True,
'lms.djangoapps.instructor_task.models': MockInstructorTaskModelsModule(),
})
@patch.object(InstructorToolBlock, 'user_is_staff', Mock(return_value=True))
def test_pagination_multiple_results(self):
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def package_data(pkg, root_list):

setup(
name='xblock-problem-builder',
version='2.6.0',
version='2.6.1',
description='XBlock - Problem Builder',
packages=['problem_builder', 'problem_builder.v1'],
install_requires=[
Expand Down