feat: Support for login and registration via a browser custom tab #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for logging in and registering a new account using the browser. This can be useful for cases where the only way to log into the instance is via a custom third-party auth provider.
xitij2000
force-pushed
the
kshitij/custom-auth-eshe-mvp
branch
from
c12e444
to
60675bd
Compare
navinkarkera
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
- I tested this: Tested as part of feat: Support for login and registration via a browser custom tab openedx/openedx-app-android#371
- I read through the code
- I checked for accessibility issues
- Includes documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for logging in and registering a new account using the browser. This can be useful for cases where the only way to log into the instance is via a custom third-party auth provider.