-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse custom formats when changing input text #63
Conversation
You are right @AnalogMemory |
Fixed as of 21/04/2023 @AnalogMemory @onesine |
Hi @t0m3k 👋 |
I see this PR is merged but still don't get the user input to trigger onchange. |
Hi @walidmahade 👋 Thanks for your feedback. The PR is indeed merger, but we haven't released a new version yet. We are waiting to have a number of features before we can release a new version. |
@onesine could releasing be made a priority? It would be nice to have one new feature if it's ready rather than wait for a bundle 😄 |
Hi @poshiemaaat 👋 . I understand your concern. So I'll publish a new release. |
Woo hoo! Thank you @onesine Now that I tried it out, it does look like hard coded input slices is not necessarily working. For example, if I use <Datepicker
asSingle={true}
displayFormat="MMMM D, YYYY"
/> This doesn't update, correct? The issue is that "May 11, 2023" is more than 10 characters, making it an invalid date. I could circumvent this by removing the year for now. I'm also not entirely sure what the best solution may be; perhaps slice on either nothing or the Want me to write a bug ticket or try to create a PR? |
@poshiemaaat thanks for input. I've created a new pull request with the issue hopefully solved. #132 I tried specifically your date format both asSingle and not and seemed to be working, as well as for other popular date formats. I made a separate pull request, as it changes the way manual input works. |
Parse custom formats when using input text