Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added handling for failed state #286

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Apr 9, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes onepanelio/core#

Special notes for your reviewer:

To reproduce this before this fix, create the default nginx template, but don't provide any slack environment variables.
The workspace status icon/state in the listing page will display an error.

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@Vafilor Vafilor added this to the v0.21.0 milestone Apr 9, 2021
@Vafilor Vafilor merged commit caada83 into onepanelio:master Apr 14, 2021
@Vafilor Vafilor deleted the fix/failed.status branch April 14, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant