-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli delete command #87
Conversation
@Vafilor Wanted to bring this up for consideration.
Since it wasn't deleted, it's didn't impact the k8s cluster.
Not sure if we should point this out via code, or ignore it via code, or not worry about this error. |
@aleksandrmelnikov That's a good point, I didn't consider that case. What do you think @rushtehrani? Should we not allow default for now, just rework logic so default is allowed? |
@Vafilor I am good with disallowing |
Sounds good. How about |
I think something like |
|
… feat/onepanel.delete
@@ -12,6 +12,7 @@ func DeploymentStatus(yamlFile *DynamicYaml) (ready bool, err error) { | |||
namespacesToCheck["application-system"] = true | |||
namespacesToCheck["onepanel"] = true | |||
namespacesToCheck["istio-system"] = true | |||
namespacesToCheck["default"] = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vafilor added default
to reserved ns list here
What this PR does:
Adds a basic delete command.
Which issue(s) this PR fixes:
Fixes onepanelio/onepanel#270
Special notes for your reviewer:
This does not wait to see if all resources have been deleted, so it may take the cluster a few seconds to delete everything.
Use in conjunction with: onepanelio/manifests#102