Make hasShouldComponentUpdate detect nested functions

[adamschoenemann]

I haven't tested it thoroughly, but it works for me! :)

[mikaelbr]

Could this be changed to Array.isArray? instanceof checks are generally not too good in JS.

[adamschoenemann]

Sure, no problem

[mikaelbr]

Is this something that React supports as well? Never seen nested objects as mixins in React before. Could you possibly do a test verifying this as well?

[adamschoenemann]

Well, React certainly supports nested mixins. React does not attempt to set a default shouldComponentUpdate via a mixin operation, so this is not really an in issue.
As a user, I would expect the omniscient shouldComponentUpdate would only be supplied if I had not supplied one, through nested mixins or not - but maybe that's just me!

This example works fine with React:

var BaseHandler = {
    shouldComponentUpdate() {
        console.log('BaseHandler shouldComponentUpdate!');
        return true;
    }
};

var AppHandler = {
    mixins: [BaseHandler]
};

var FooHandler = React.createClass({
    mixins: [AppHandler],
    getInitialState() {
        return {foo: 1};
    },
    componentDidMount() {
        window.setTimeout(() => {
            this.setState({foo: this.state.foo + 1});
        }, 500);
    },
    render() {
        return DOM.div(null,
            this.state.foo,
            'FooHandler!'
        );
    }
});

Whereas with Omniscient, React will throw an error when attempting to set shouldComponentUpdate, as it is already defined by the nested mixin.

[mikaelbr]

I see. This would fix that, so very good! 🍰

[adamschoenemann]

Great! 👍