Retrieves response available options from ruby-saml #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SAML-Toolkits/ruby-saml#454 was introduced a whitelisting for allowed Response options.
In my previous pr #159 I added one more option.
According to me, this whitelist introduced in 4712e99 should not be a responsibility of
omniauth-saml
but it should be provided out of the box byruby-saml
. It looked like @md5 agreed on this point (#159 (comment))Since
'ruby-saml' ~>1.8
integrated this change, I updated the dependency of this gem and retrieved response available options from it.