Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usability of Project.WildCardDedup #1304

Closed
oleg-shilo opened this issue Jul 1, 2023 · 1 comment
Closed

Improve usability of Project.WildCardDedup #1304

oleg-shilo opened this issue Jul 1, 2023 · 1 comment
Labels
Done / Released enhancement

Comments

@oleg-shilo
Copy link
Owner

This issue is the result of the comprehensive discussion of Issue #270.

Project.WildCardDedup should be implemented according to this definition:

When ResolveWildCards is invoked, it inserts the files discovered from project's DirFiles and Files definitions. For every Dir, which gets new discovered files, the global dedup delegate Project.WildCardDedup will be invoked.
@oleg-shilo oleg-shilo mentioned this issue Jul 1, 2023
Closed
@oleg-shilo oleg-shilo changed the title Improve usanility of Project.WildCardDedup Improve usability of Project.WildCardDedup Jul 1, 2023
oleg-shilo added a commit that referenced this issue Jul 1, 2023
@oleg-shilo
- Issues #1304: Improve usability of Project.WildCardDedup
38ae96f 
- Renamed `Dir.DirFileCollections` -> `Dir.DirFilesCollections`
- Renamed `Dir.FileCollections` -> `Dir.FilesCollections`
@oleg-shilo oleg-shilo mentioned this issue Jul 1, 2023
Merged
oleg-shilo added a commit that referenced this issue Jul 1, 2023
@oleg-shilo
Release v1.22.0
37523df 
- Updated WiX binaries to v3.14.0.6526
- Updated samples to reflect WiX v3.14.0.6526
- Updated WixSharp.wix.bin.nuspec
- Issue #1297: wixsharp:WpfDialog auto scaling based on screen resolu…
- Extra u-tests for #270
- Issue #1300: Weird space sin FeaturesDialog title
- Issue #1301: Make more elements translatable
- RC preparation
- Issues #1304: Improve the usability of Project.WildCardDedup
@Lumoryel
Copy link

Lumoryel commented Jul 3, 2023

Hi Oleg, thanks for clearing this up and implementing it!

I tested Version 1.22 and for me it now does what I need and what I would expect.

So just to make sure I understood your definition correctly:

"In ResolveWildCards(), for every (Target-) Dir that has one or multiple (Source-) DirFiles or Files, the WildcardDedup is called exactly once (to ensure there aren't multiple files with the same name in the same target directory)".

Is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Done / Released enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oleg-shilo @Lumoryel