Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test workflow #120

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix test workflow #120

merged 2 commits into from
Nov 17, 2022

Conversation

ad2ien
Copy link
Contributor

@ad2ien ad2ien commented Nov 16, 2022

cargo-make released a new version (0.36.3) which, for some reason, caused the test workflow to fail. This PR make it work again 🤷

@ad2ien ad2ien changed the title chore: confirm ci issue comes from coverage try to fix test workflow Nov 16, 2022
@ad2ien ad2ien changed the title try to fix test workflow Try to fix test workflow WIP Nov 16, 2022
@ad2ien ad2ien force-pushed the ci/fix-test branch 2 times, most recently from 865792e to 106cf42 Compare November 16, 2022 10:24
@ad2ien ad2ien changed the title Try to fix test workflow WIP Fix test workflow Nov 16, 2022
@ad2ien ad2ien self-assigned this Nov 16, 2022
@ad2ien ad2ien requested a review from bdeneux November 16, 2022 10:36
@ad2ien ad2ien marked this pull request as ready for review November 16, 2022 10:36
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very strange, after checking workflow logs, I saw an error that is not return non-zero code and workflow is successful. It's been a long time that this error exist and we didn't see it and I think the new version of cargo make introduce this.

Capture d’écran 2022-11-16 à 14 07 37

Makefile.toml Outdated Show resolved Hide resolved
@ad2ien ad2ien force-pushed the ci/fix-test branch 7 times, most recently from 0d029a0 to ad294e3 Compare November 16, 2022 16:56
@ad2ien ad2ien marked this pull request as draft November 16, 2022 16:56
@ad2ien ad2ien force-pushed the ci/fix-test branch 2 times, most recently from 5c654bc to ca028b5 Compare November 17, 2022 06:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #120 (118d3be) into main (e1e22b3) will increase coverage by 0.12%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #120      +/-   ##
========================================
+ Coverage   1.42%   1.54%   +0.12%     
========================================
  Files         28      32       +4     
  Lines        845     905      +60     
========================================
+ Hits          12      14       +2     
- Misses       833     891      +58     
Impacted Files Coverage Δ
src/cli/commands/start.rs 0.96% <0.00%> (-0.07%) ⬇️
src/cli/config.rs 0.00% <0.00%> (ø)
src/cosmos/faucet/discord_message.rs 0.00% <0.00%> (ø)
src/cosmos/faucet/handlers/request_funds.rs 0.00% <0.00%> (ø)
src/cosmos/faucet/handlers/tx_response.rs 0.00% <0.00%> (ø)
src/cosmos/faucet/mod.rs 0.00% <0.00%> (ø)
src/cosmos/tx/actor.rs 0.00% <ø> (ø)
src/cosmos/tx/error.rs 0.00% <ø> (ø)
src/cosmos/tx/handlers/register_handler.rs 0.00% <0.00%> (ø)
src/cosmos/tx/handlers/register_msg.rs 0.00% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ad2ien
Copy link
Contributor Author

ad2ien commented Nov 17, 2022

@bdeneux I finally almost set it back like it was... but now I know why 😉

@ad2ien ad2ien marked this pull request as ready for review November 17, 2022 07:32
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for the fix 🙏
Very strange that cargo make doesn't install the rust component but is not the first time that cargo make is not working well :/

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

@ad2ien ad2ien merged commit 5a6cc4b into main Nov 17, 2022
@ad2ien ad2ien deleted the ci/fix-test branch November 17, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants