Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: markdown table links check #33

Merged
merged 4 commits into from
Jul 7, 2023
Merged

feat: markdown table links check #33

merged 4 commits into from
Jul 7, 2023

Conversation

alexandrglaznyov
Copy link
Contributor

This pull request includes the following changes:

  • Moved JavaScript-related files (index.js, package.json, package-lock.json) to ./github/scripts directory.
  • Added a new GitHub Action named update-service-status-badges.yml.
  • Configured manual triggering of the GitHub Action using workflow_dispatch.
  • Enhanced the functionality of the action by adding a cron schedule.
  • Added the commit message to "docs: update url service status badges".
  • Added a script that edits the README.md file to check link status based on the URL column in each service table
  • Added a helper directory with corresponding code for link checking
  • Updated the README.md file to separate the Services table into multiple tables (RPC, API, gRPC, etc.) for better visibility of individual service statuses
  • Added a status column to the Block Explorers, Documentation / Guides, and Dashboards tables for monitoring link functionality

@RuslanGlaznyov RuslanGlaznyov mentioned this pull request Jul 5, 2023
Closed
ccamel
ccamel requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 👍 Just some minor changes requested on my side - it would so great it if you could take them into consideration.

.github/workflows/update-service-status-badges.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ccamel ccamel self-requested a review July 6, 2023 14:38
ccamel
ccamel approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your great contribution.

amimart
amimart approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a lot 🙏

bdeneux
bdeneux approved these changes Jul 7, 2023
View reviewed changes
Copy link

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ! Thanks 👍

Just one question about package.json but otherwise it seems very good ! Thanks.

.github/scripts/package.json Outdated Show resolved Hide resolved
@ccamel
Copy link
Member

ccamel commented Jul 7, 2023

Everything looks good! Time to merge. 😄

@ccamel ccamel self-assigned this Jul 7, 2023
@ccamel ccamel merged commit 79f58d6 into okp4:main Jul 7, 2023
6 of 7 checks passed
@ccamel ccamel mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccamel ccamel ccamel approved these changes

@amimart amimart amimart approved these changes

@bdeneux bdeneux bdeneux approved these changes

@jeremylgn jeremylgn jeremylgn approved these changes

Assignees

@ccamel ccamel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandrglaznyov @ccamel @amimart @bdeneux @jeremylgn