Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define multi-period investment storage level for very first time step of optimization #965

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

jokochems
Copy link
Member

Add a constraint to force initial storage level to 0 in case of multi-period investment modelling to prevent storage from being filled without any associated costs in case of investments in the first period.

@jokochems jokochems marked this pull request as ready for review August 4, 2023 16:30
Copy link
Contributor

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in rule formulation that I am proposing is not mandatory.

I didn't check all the LP file changes in detail, as most of it are just changes in the line order besides the new rule.
Thanks for fixing this right away!

src/oemof/solph/components/_generic_storage.py Outdated Show resolved Hide resolved
@nailend
Copy link
Contributor

nailend commented Aug 7, 2023

With this, the SuspiciousUsageWarning can be changed to an error?

@jokochems
Copy link
Member Author

With this, the SuspiciousUsageWarning can be changed to an error?

Yes, that's a good suggestion.

@p-snft p-snft added this to the v0.5.1 milestone Aug 8, 2023
@p-snft
Copy link
Member

p-snft commented Aug 10, 2023

Makes sense for me. I will merge this.

@p-snft p-snft merged commit 869b60b into dev Aug 10, 2023
12 checks passed
@p-snft p-snft deleted the fix/multi-period-investment-storage-limit branch August 10, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenericInvestmentStorageBlock lacks limitation of initial storage level for multi-period investments
3 participants