Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): remove browser build #487

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix(build): remove browser build #487

merged 2 commits into from
Jun 21, 2023

Conversation

wolfy1339
Copy link
Member

Follow-up to #479


Behavior

Before the change?

  • A browser build was being generated when this package is not meant for browser usage

After the change?

  • Removes the browser build

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 9, 2023
@wolfy1339
Copy link
Member Author

A browser build was being generated before with Pika

@gr2m gr2m merged commit 2e739c0 into main Jun 21, 2023
7 checks passed
@gr2m gr2m deleted the wolfy1339-patch-1 branch June 21, 2023 21:46
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants