fix(build): replace Pika with esbuild and tsc

.github/workflows/release.yml

@@ -18,9 +18,6 @@ jobs:
           cache: npm
       - run: npm ci
       - run: npm run build
-      # https://github.com/octokit/auth-app.js/pull/475
-      - name: "Fix pkg.files file pattern"
-        run: node scripts/fix-package-json.js
       - run: npx semantic-release
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

package.json

@@ -6,7 +6,7 @@
   "version": "0.0.0-development",
   "description": "GitHub App authentication for JavaScript",
   "scripts": {
-    "build": "pika-pack build",
+    "build": "node scripts/build.mjs && tsc -p tsconfig.json",
     "lint": "prettier --check '{src,test}/**/*.{ts,md}' README.md *.json",
     "lint:fix": "prettier --write '{src,test}/**/*.{ts,md}' README.md *.json",
     "pretest": "npm run -s lint",
@@ -34,16 +34,15 @@
     "universal-user-agent": "^6.0.0"
   },
   "devDependencies": {
-    "@pika/pack": "^0.3.7",
-    "@pika/plugin-build-node": "^0.9.0",
-    "@pika/plugin-build-web": "^0.9.0",
-    "@pika/plugin-ts-standard-pkg": "^0.9.0",
+    "@octokit/tsconfig": "^1.0.2",
     "@sinonjs/fake-timers": "^8.0.0",
     "@types/fetch-mock": "^7.3.1",
     "@types/jest": "^29.0.0",
     "@types/node": "^18.11.18",
     "@types/sinonjs__fake-timers": "^8.0.0",
+    "esbuild": "^0.17.19",
     "fetch-mock": "^9.0.0",
+    "glob": "^10.2.5",
     "jest": "^29.0.0",
     "prettier": "2.8.8",
     "semantic-release-plugin-update-version-in-files": "^1.0.0",
@@ -61,22 +60,6 @@
       }
     }
   },
-  "@pika/pack": {
-    "pipeline": [
-      [
-        "@pika/plugin-ts-standard-pkg"
-      ],
-      [
-        "@pika/plugin-build-node",
-        {
-          "minNodeVersion": "14"
-        }
-      ],
-      [
-        "@pika/plugin-build-web"
-      ]
-    ]
-  },
   "release": {
     "branches": [
       "+([0-9]).x",

scripts/build.mjs

@@ -0,0 +1,92 @@
+// @ts-check
+import esbuild from "esbuild";
+import { copyFile, readFile, writeFile, rm } from "fs/promises";
+import { glob } from "glob";
+
+/**
+ * @type {esbuild.BuildOptions}
+ */
+const sharedOptions = {
+  sourcemap: "external",
+  sourcesContent: true,
+  minify: false,
+  allowOverwrite: true,
+  packages: "external",
+};
+
+async function main() {
+  // Start with a clean slate
+  await rm("pkg", { recursive: true, force: true });
+  // Build the source code for a neutral platform as ESM
+  await esbuild.build({
+    entryPoints: await glob(["./src/*.ts", "./src/**/*.ts"]),
+    outdir: "pkg/dist-src",
+    bundle: false,
+    platform: "neutral",
+    format: "esm",
+    ...sharedOptions,
+    sourcemap: false,
+  });
+
+  // Remove the types file from the dist-src folder
+  const typeFiles = await glob([
+    "./pkg/dist-src/**/types.js.map",
+    "./pkg/dist-src/**/types.js",
+  ]);
+  for (const typeFile of typeFiles) {
+    await rm(typeFile);
+  }
+
+  const entryPoints = ["./pkg/dist-src/index.js"];
+
+  await Promise.all([
+    // Build the a CJS Node.js bundle
+    esbuild.build({
+      entryPoints,
+      outdir: "pkg/dist-node",
+      bundle: true,
+      platform: "node",
+      target: "node14",
+      format: "cjs",
+      ...sharedOptions,
+    }),
+    // Build an ESM browser bundle
+    esbuild.build({
+      entryPoints,
+      outdir: "pkg/dist-web",
+      bundle: true,
+      platform: "browser",
+      format: "esm",
+      ...sharedOptions,
+    }),
+  ]);
+
+  // Copy the README, LICENSE to the pkg folder
+  await copyFile("LICENSE", "pkg/LICENSE");
+  await copyFile("README.md", "pkg/README.md");
+
+  // Handle the package.json
+  let pkg = JSON.parse((await readFile("package.json", "utf8")).toString());
+  // Remove unnecessary fields from the package.json
+  delete pkg.scripts;
+  delete pkg.prettier;
+  delete pkg.release;
+  delete pkg.jest;
+  await writeFile(
+    "pkg/package.json",
+    JSON.stringify(
+      {
+        ...pkg,
+        files: ["dist-*/**", "bin/**"],
+        main: "dist-node/index.js",
+        module: "dist-web/index.js",
+        types: "dist-types/index.d.ts",
+        source: "dist-src/index.js",
+        sideEffects: false,
+      },
+      null,
+      2
+    )
+  );
+}
+main();

test/index.test.ts

@@ -334,7 +334,7 @@ test("installationId strategy option fails with no installationId", async () =>
 
 test("repositoryIds auth option", async () => {
   const matchCreateInstallationAccessToken: MockMatcherFunction = (
-    url,
+    _url,
     { body }
   ) => {
     expect(JSON.parse(String(body))).toStrictEqual({
@@ -399,7 +399,7 @@ test("repositoryIds auth option", async () => {
 
 test("repositoryNames auth option", async () => {
   const matchCreateInstallationAccessToken: MockMatcherFunction = (
-    url,
+    _url,
     { body }
   ) => {
     expect(JSON.parse(String(body))).toStrictEqual({
@@ -464,7 +464,7 @@ test("repositoryNames auth option", async () => {
 
 test("Consistenly handling reposID & reposName", async () => {
   const matchCreateInstallationAccessToken: MockMatcherFunction = (
-    url,
+    _url,
     { body }
   ) => {
     expect(JSON.parse(String(body))).toStrictEqual({
@@ -529,7 +529,7 @@ test("Consistenly handling reposID & reposName", async () => {
 
 test("permissions auth option", async () => {
   const matchCreateInstallationAccessToken: MockMatcherFunction = (
-    url,
+    _url,
     { body }
   ) => {
     expect(JSON.parse(String(body))).toStrictEqual({
@@ -764,11 +764,11 @@ test("installation auth with selected permissions from cache", async () => {
 });
 
 test("installation cache with different options", async () => {
-  const matchCreateAccessToken1: MockMatcherFunction = (url, { body }) => {
+  const matchCreateAccessToken1: MockMatcherFunction = (_url, { body }) => {
     expect(body).toBeUndefined();
     return true;
   };
-  const matchCreateAccessToken2: MockMatcherFunction = (url, { body }) => {
+  const matchCreateAccessToken2: MockMatcherFunction = (_url, { body }) => {
     expect(JSON.parse(String(body))).toStrictEqual({
       permissions: {
         metadata: "read",
@@ -1786,7 +1786,7 @@ test("auth.hook(): handle 401 in first 5 seconds (#65)", async () => {
       },
       repository_selection: "all",
     })
-    .get("https://api.github.com/repos/octocat/hello-world", (url) => {
+    .get("https://api.github.com/repos/octocat/hello-world", () => {
       if (Date.now() < FIVE_SECONDS_IN_MS) {
         return {
           status: 401,
@@ -1877,7 +1877,7 @@ test("auth.hook(): throw error with custom message after unsuccessful retries (#
       },
       repository_selection: "all",
     })
-    .get("https://api.github.com/repos/octocat/hello-world", (url) => {
+    .get("https://api.github.com/repos/octocat/hello-world", () => {
       return {
         status: 401,
         body: {

tsconfig.json

@@ -1,10 +1,11 @@
 {
+  "extends": "@octokit/tsconfig",
   "compilerOptions": {
     "esModuleInterop": true,
-    "module": "esnext",
-    "moduleResolution": "node",
-    "strict": true,
-    "target": "es2018"
+    "declaration": true,
+    "outDir": "pkg/dist-types",
+    "emitDeclarationOnly": true,
+    "sourceMap": true
   },
   "include": ["src/**/*"]
 }