Skip to content

Commit

Permalink
fix(typescript): mark imports/exports that are only used for types ex…
Browse files Browse the repository at this point in the history
…plicitely (#480)
  • Loading branch information
wolfy1339 committed May 19, 2023
1 parent f588939 commit 0d757a9
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/auth.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Deprecation } from "deprecation";
import * as OAuthAppAuth from "@octokit/auth-oauth-app";

import {
import type {
Authentication,
State,
AppAuthOptions,
Expand Down
2 changes: 1 addition & 1 deletion src/cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { LRUCache } from "lru-cache";

/* istanbul ignore next */
import {
import type {
InstallationAuthOptions,
Cache,
CacheData,
Expand Down
2 changes: 1 addition & 1 deletion src/get-app-authentication.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { githubAppJwt } from "universal-github-app-jwt";

import { AppAuthentication, State } from "./types";
import type { AppAuthentication, State } from "./types";

export async function getAppAuthentication({
appId,
Expand Down
2 changes: 1 addition & 1 deletion src/get-installation-authentication.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { get, set } from "./cache";
import { getAppAuthentication } from "./get-app-authentication";
import { toTokenAuthentication } from "./to-token-authentication";
import {
import type {
InstallationAuthOptions,
InstallationAccessTokenAuthentication,
RequestInterface,
Expand Down
2 changes: 1 addition & 1 deletion src/hook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { RequestError } from "@octokit/request-error";
import { getAppAuthentication } from "./get-app-authentication";
import { getInstallationAuthentication } from "./get-installation-authentication";
import { requiresAppAuth } from "./requires-app-auth";
import {
import type {
AnyResponse,
EndpointOptions,
RequestParameters,
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import { createOAuthAppAuth } from "@octokit/auth-oauth-app";
import { auth } from "./auth";
import { hook } from "./hook";
import { getCache } from "./cache";
import { AuthInterface, State, StrategyOptions } from "./types";
import type { AuthInterface, State, StrategyOptions } from "./types";
import { VERSION } from "./version";

export { createOAuthUserAuth } from "@octokit/auth-oauth-user";
export {
export type {
// strategy options
StrategyOptions,
// auth options
Expand Down
2 changes: 1 addition & 1 deletion src/to-token-authentication.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {
import type {
CacheData,
InstallationAccessTokenAuthentication,
WithInstallationId,
Expand Down

0 comments on commit 0d757a9

Please sign in to comment.