Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raised meaningful exceptions instead of assert statements #137

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thejasmeetsingh
Copy link

The changes included in this PR are done with regards to this raised issue #85

Copy link
Contributor

@samueljsb samueljsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! It looks like you're our first contributor from a fork, so I think we need to fix some setting to make sure the tests run on this branch -- sorry for the delay while we sort that out.

Would you mind adding tests for this new behaviour, please? We'd also like to keep the commit history a bit cleaner, so if you could squash the commits into one that would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants