Dbt cert josh #26
Dbt cert josh #26
Conversation
joshuadias2212
force-pushed
the
dbt_cert_josh
branch
from
06d42b0
to
2602696
Compare
|
Also small not on commits - they should start with a capitalised imperative verb. That means 'added' -> 'Add' ; 'updated' -> 'Update' |
| WITH returned_orders AS ( | ||
| SELECT | ||
| orders.customer_id AS customer_id | ||
| orders.amount as total_amount |
There was a problem hiding this comment.
I don't think this SQL would run - do you know why?
There was a problem hiding this comment.
Ah, missing comma, thanks
There was a problem hiding this comment.
I think it won't run because you're referencing an alias (orders) without assigning it first. Also, FYI we use leading rather than trailing commas:
SELECT
customer_id
, SUM(COALESCE(total_amount, 0)) AS total_value
FROM returned_orders
GROUP BY customer_id
| @@ -1,6 +1,6 @@ | |||
| with customers as ( | |||
|
|
|||
| select * from {{ ref('stg_customers') }} | |||
| select * from {{ ref('stg_customers_pii') }} | |||
|
|
|||
| ), | |||
|
|
|||
There was a problem hiding this comment.
I've missed this in other PRs - SELECT * from cte's should generally not be used (only select columns that will be used ) + because this model uses PII, it should be renamed wh_customers_pii and put in the sensitive schema. No need to do this.
There was a problem hiding this comment.
Sure, I'll revert this change then to just select from stg_customers
joshuadias2212
force-pushed
the
dbt_cert_josh
branch
from
598933f
to
57c7e97
Compare
joshuadias2212
force-pushed
the
dbt_cert_josh
branch
5 times, most recently
from
f1358e5
to
f1c5198
Compare
joshuadias2212
force-pushed
the
dbt_cert_josh
branch
from
f1c5198
to
2036dac
Compare
No description provided.