Fix input text cursor movement tests #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblocks imgui/pull/6067
ajweeks
commented
Jan 29, 2023
| IM_CHECK_EQ(state->GetCursorPos(), 6 + 5); // "Hello world|. Foo.bar!!!" // VS-Win: STOP, GitHubWeb-Win: SKIP | ||
| KeyPressAndDebugPrint(chord_word_prev); | ||
| #endif | ||
| IM_CHECK_EQ(state->GetCursorPos(), 6); // "Hello |world. Foo.bar!!!" | ||
|
|
||
| KeyPressAndDebugPrint(chord_word_prev); | ||
| IM_CHECK_EQ(state->GetCursorPos(), 0); // "|Hello world. Foo.bar!!!" | ||
|
|
||
| KeyPressAndDebugPrint(chord_word_prev); | ||
| IM_CHECK_EQ(state->GetCursorPos(), 0); // "|Hello world. Foo.bar!!!" // (no-op) |
There was a problem hiding this comment.
Not sure if this functionality is tested elsewhere and this test is useless or not.
ajweeks
commented
Jan 29, 2023
| } | ||
| else | ||
| { | ||
| // OSX | ||
| KeyPressAndDebugPrint(chord_word_next); | ||
| IM_CHECK_EQ(state->GetCursorPos(), 5); // "Hello|" | ||
| ImGui::SetActiveID(state->ID, ImGui::GetCurrentWindow()); |
There was a problem hiding this comment.
These lines were necessary for me to test on Windows since the Alt keypress will change the focus to the dropdown arrow, causing the next keypress to not be registered by the inputtext widget. Of course a more robust solution is needed but I couldn't find one quickly.
There was a problem hiding this comment.
That part was actually a bug on OSX which was fixed by fc50532 around the time you made that PR, so I'm removing those lines now.
ocornut
force-pushed
the
main
branch
2 times, most recently
from
aa12207
to
057b5a9
Compare
ocornut
pushed a commit
that referenced
this pull request
Mar 22, 2023
…in order to support separator changes (#9) Main repo: Unblocks imgui/pull/6067
|
Merged as cc40e07, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks imgui/pull/6067
This change fixes a couple of bugs in the input text tests, and changes the ifdef checks to check against a version number (which may be the incorrect one once the PR in the main repo is merged). I'm also not confident that these tests will pass with older version of ImGui due to not being able to test them, though if they worked before then they still should now.