Fix SetItemDefaultFocus() consistency #2810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue that an item which was barely visible (1px) was not being visibly focused. Also always focusing the default item in the center of the surrounding area makes it behave consistently independent of initial visibility. Both of which are being resolved with this change. Additional suggestion: Introduce optional center_y_ratio parameter to forward to SetScrollHereY() for more control.
|
Would need more work, see #2812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue that an item which was barely visible (1px) was not being visibly focused. Also always focusing the default item in the center of the surrounding area makes it behave consistently independent of initial visibility. Both of which are being resolved with this change.
Additional suggestion: Introduce optional
center_y_ratioparameter to forward to SetScrollHereY() for more control.Dear ImGui 1.73