Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Picker widget does not provide a perfect color #3517

Closed
christt105 opened this issue Oct 10, 2020 · 1 comment
Closed

Color Picker widget does not provide a perfect color #3517

christt105 opened this issue Oct 10, 2020 · 1 comment
Labels
coloredit

Comments

@christt105
Copy link

Version/Branch of Dear ImGui:

Version: 1.77 WIP (17601)
Branch: docking

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_opengl3.cpp + imgui_impl_sdl.cpp
Compiler: VS 2019
Operating System: Windows 10

My Issue/Question:

Choosing a color (e.g. white) dragging the circle on the ColorPicker widget, the red float value is correct (1.0f) but the green and blue variables have a value of almost 1, but not exactly (0.999989986f).

Screenshots/Video

image
image

Thanks in advance!
rokups added a commit to rokups/imgui that referenced this issue Apr 12, 2021
@rokups
ColorEdit: Fix not being able to display (1.0f, 1.0f, 1.0f) color. (o…
f8a241d 
…cornut#3517)
rokups added a commit to rokups/imgui that referenced this issue Apr 12, 2021
@rokups
ColorEdit: Fix not being able to display (1.0f, 1.0f, 1.0f) color. (o…
09e0f51 
…cornut#3517)

Old code attempted to mitigate hue/saturation resetting for colors where these components are undefined. Since we now explicitly back up and restore these components this workaround is no longer necessary.
rokups added a commit to rokups/imgui that referenced this issue Apr 12, 2021
@rokups
ColorEdit: Fix not being able to display (1.0f, 1.0f, 1.0f) color. (o…
f673593 
…cornut#3517)

Old code attempted to mitigate hue/saturation resetting for colors where these components are undefined. Since we now explicitly back up and restore these components this workaround is no longer necessary.
rokups added a commit to rokups/imgui that referenced this issue Sep 21, 2021
@rokups
ColorEdit: Fix not being able to display (1.0f, 1.0f, 1.0f) color. (o…
1961624 
…cornut#3517)

Old code attempted to mitigate hue/saturation resetting for colors where these components are undefined. Since we now explicitly back up and restore these components this workaround is no longer necessary.
ocornut pushed a commit that referenced this issue Sep 21, 2021
@rokups @ocornut
ColorPicker: Fix not being able to pick exactly (1.0f, 1.0f, 1.0f) co…
15fe7ba 
…lor by dragging toward the edges of the SV square. (#3517)

Old code attempted to mitigate hue/saturation resetting for colors where these components are undefined. Since we now explicitly back up and restore these components this workaround is no longer necessary.
@ocornut
Copy link
Owner

ocornut commented Sep 21, 2021

This should now be fixed by 15fe7ba, thanks for reporting!

@ocornut ocornut closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coloredit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocornut @christt105