Filter verification tests #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in the old version, grid scale and filter scale were chosen as equal; filtering does not really do anything in that case
rabernat
reviewed
May 24, 2022
| da_v = xr.DataArray(data_v, dims=["y", "x"]) | ||
|
|
||
| return grid_type, da_u, da_v, grid_vars, geolat_u | ||
|
|
There was a problem hiding this comment.
Can you just help me understand why all this code is being removed? Is it redundant with the code in conftest.py?
There was a problem hiding this comment.
Yes, exactly. The only two differences between the removed code and the code in conftest.py were:
conftest.pycreated numpy array test data (specific totest_kernels.py), whereas the removed code created xarray DataArray test data (specific totest_filter.py). The new fixturesgrid_type_and_input_dsandvector_grid_type_and_input_dsinconftest.pytake care of the numpy array--> xarray DataArray conversion, but without all the redundancy.- The random number generator for the test data. Using the explicit constant seed for the random number generator in
conftest.pyensures that we are always testing on the same data - a pre-requisite for the filter verification tests, exactly as done in Refactor kernel tests #79.
|
@rabernat do you agree that we can merge this PR? |
|
Thanks for the ping Nora! Yes, absolutely, I will do it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds verification tests for the filter algorithm, in preparation for the refactor in #149, which replaces the filter algorithm with a new one.
This PR essentially mirrors #79, but here the verification tests are associated with the
test_filter.pymodule (rather than thetest_kernels.pymodule as in #79). The main changes are:tests/test_filter.pytotests/conftest.pyand, in the process, got rid off a lot of redundant code.test_filter_validation.py.