Factoring the Gaussian - Part 3 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
iangrooms
reviewed
Feb 7, 2022
gcm_filters/filter.py
Outdated
| @@ -421,14 +423,14 @@ def plot_shape(self, ax=None): | |||
| linewidth=4, | |||
| ) | |||
| ax.axvline( | |||
| 2 * np.pi / self.filter_scale, | |||
| 2 * np.pi / self.filter_scale_iterated, | |||
There was a problem hiding this comment.
On the lines above, the target that is plotted is F(x) ** self.n_iterations and the approximation that is plotted is np.polynomial.chebyshev.chebval(x, self.filter_spec.p) ** self.n_iterations. For these plots I think we want the vertical line to be at filter_scale not filter_scale_iterated right?
(Edit: Same comment applies to the zoomed-in plot below)
|
OK, looks good to me. Thanks @NoraLoose! |
|
Thanks Ian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few minor tweaks to code and documentation related to factoring the Gaussian.
self.filter_scaleandself.filter_scale_iterated. As a result, the string representation of the filter can give back the original filter scale (self.filter_scale) that the user put in, rather than the smaller filter scale associated with the constituent filters. I think this makes it more intuitive.factored_gaussian.rstto exemplify the factoring.