Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with (bisect_ppx) and (lang dune 2.5) #3473

Closed
aantron opened this issue May 10, 2020 · 2 comments
Closed

Crash with (bisect_ppx) and (lang dune 2.5) #3473

aantron opened this issue May 10, 2020 · 2 comments
Labels
Milestone

Comments

@aantron
Copy link
Collaborator

aantron commented May 10, 2020

Expected Behavior

If one accidentally does not use (lang dune 2.6), Dune should print a neat error message that (bisect_ppx) requires 2.6.

Actual Behavior

Internal error, please report upstream including the contents of _build/log.

Reproduction

  1. git clone https://github.com/aantron/lambdasoup.git
  2. cd lambdasoup
  3. git checkout dune+bisect
  4. Edit dune-project to have (lang dune 2.5)
  5. dune runtest

Specifications

  • Version of dune (output of dune --version): 2.5.1-99-gf6ef0be5
  • Version of ocaml (output of ocamlc --version): 4.08.0
  • Operating system (distribution and version): WSL

Additional information

@ghost
Copy link

ghost commented May 12, 2020

Agreed

@ghost ghost added this to the 2.6 milestone May 12, 2020
@ghost
Copy link

ghost commented May 12, 2020

Adding to the 2.6 milestone because that should be easy to fix and it seems like something we should fix before releasing support for bisect_ppx.

rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue May 30, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant