Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug - buf must be null terminated #2

Merged
merged 1 commit into from
Aug 13, 2015
Merged

Conversation

josealf
Copy link
Contributor

@josealf josealf commented Jul 23, 2015

buf string may contain previous data. Make sure it is null terminated. This patch is a fix for incorrect database name entries when importing a configuration file. For example, a merge file like this:
DATABASES\TEST\DB INFO\TYPE = STANDARD
DATABASES\TEST\DB INFO\PATH = C:\Data
DATABASES\TEST\DB INFO\ENABLE BCD = FALSE
DATABASES\TEST\DB INFO\DEFAULT DRIVER = PARADOX
causes an entry with name TESTBASES in the final CFG file.

buf string may contain previous data. Make sure it is null terminated.
oboroc added a commit that referenced this pull request Aug 13, 2015
Fix bug - buf must be null terminated
@oboroc oboroc merged commit 4a48981 into oboroc:master Aug 13, 2015
@oboroc
Copy link
Owner

oboroc commented Aug 13, 2015

Thanks for the bugfix! I'll probably need to build some sort of test unit for it.

@josealf
Copy link
Contributor Author

josealf commented Aug 13, 2015

You're welcome. Your utility came very handy for a recent project. I'm glad I was able to contribute back.

@oboroc
Copy link
Owner

oboroc commented Aug 14, 2015

Hi, do you mind sending a quick email with copyright assignment for your
patch? It is so I can change license in future if necessary, for example
from apache to gplv2 or mit. Not very likely for such a tiny tool, but who
knows. Also I would appreciate if you star it in github.

Thanks :)
Adrian
On Aug 13, 2015 7:51 PM, "josealf" notifications@github.com wrote:

You're welcome. Your utility came very handy for a recent project. I'm
glad I was able to contribute back.


Reply to this email directly or view it on GitHub
#2 (comment).

@josealf
Copy link
Contributor Author

josealf commented Aug 14, 2015

Adrian,

It's a very small patch. Consider it public domain. Feel free to use as you freely.

El 13/8/2015, a las 19:35, Adrian Oboroc notifications@github.com escribió:

Hi, do you mind sending a quick email with copyright assignment for your
patch? It is so I can change license in future if necessary, for example
from apache to gplv2 or mit. Not very likely for such a tiny tool, but who
knows. Also I would appreciate if you star it in github.

Thanks :)
Adrian
On Aug 13, 2015 7:51 PM, "josealf" notifications@github.com wrote:

You're welcome. Your utility came very handy for a recent project. I'm
glad I was able to contribute back.


Reply to this email directly or view it on GitHub
#2 (comment).


Reply to this email directly or view it on GitHub.

@josealf
Copy link
Contributor Author

josealf commented Aug 14, 2015

Adrian,
Feel free to use my patch as you wish, or if you prefer: "I Jose Diaz transfer the copyright of my tiny patch for bdecli to you Adrian Bodoroc".
Btw, I see that you like small exes. I got the smallest size (11k) for bdecli using the tcc compiler (Tiny C Compiler, not Turbo C).
If you want to try, use the following comand to compile (asuming you install in c:\tcc):
c:\tcc\tcc.exe bdecli.c -Lc:\tcc\lib

 On Thursday, August 13, 2015 7:55 PM, Josealf.rm <josealf@rocketmail.com> wrote:

Adrian,
It's a very small patch. Consider it public domain. Feel free to use as you freely.

El 13/8/2015, a las 19:35, Adrian Oboroc notifications@github.com escribió:

Hi, do you mind sending a quick email with copyright assignment for your
patch? It is so I can change license in future if necessary, for example
from apache to gplv2 or mit. Not very likely for such a tiny tool, but who
knows. Also I would appreciate if you star it in github.

Thanks :)
Adrian
On Aug 13, 2015 7:51 PM, "josealf" notifications@github.com wrote:

You're welcome. Your utility came very handy for a recent project. I'm
glad I was able to contribute back.


Reply to this email directly or view it on GitHub
#2 (comment).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants