- (Bug Fix) Fixed typo in the definition of getWeeks, preventing its usage

[charlesbaynham]

As the description says, minor typo in the definition of getWeeks. Doesn't affect you unless you're making your own faces since this method is not used by default.

[objectivehtml]

I will get this merged as soon as I can. But it's helpful and makes things easier/quicker when people recompile the source and bump the version in the repo along with their pull request.

[charlesbaynham]

No problem: I didn't because some people like doing versioning themselves.
I'll put those in when I'm at my computer.

On 21 Oct 2014, at 16:46, Justin Kimbrell notifications@github.com wrote:

I will get this merged as soon as I can. But it's helpful and makes things
easier/quicker when people recompile the source and bump the version in the
repo.

—
Reply to this email directly or view it on GitHub
#150 (comment).

[objectivehtml]

I really need to get document together for best practices when submitting pull request. I usually do the versioning, but sometimes I tend to forget and submit the pull request. And now that FlipClock is on npm, I have to publish it there and the versioning is strict and semantic. There are like 3 places the version has to change, in the npm config file, in bower, and within the FlipClock.Factory object. And then... I have to make a commit to the FlipClock's home page which is in Beanstalk to get the update version on the site (kind of a pain).

If anyone knows of a better way to handle the versioning and publishing new releases, I am open to suggestions.

[charlesbaynham]

There, I've bumped the version and rebased.

As for versioning, I've not used it, but check out https://github.com/kswedberg/grunt-version. It looks like it just sets/lifts the version to/from package.json and then uses a regex search to push this to a given list of other files where it needs to go.