contracts: add support for core.CallDataPublicKey and core.CurrentEpoch #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
lubej
approved these changes
Aug 30, 2024
matevz
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Good job!
For production networks we should add a Web3 client monitoring Testnet and Mainnet call data public keys here: https://github.com/oasisprotocol/network-monitoring/tree/main/web3
CedarMist
force-pushed
the
CedarMist/cdpk_subcall
branch
from
92bab8b
to
a7cb67b
Compare
I'll be using the subcall (directly, not via the contract) in the go, python & js clients, so if encrypted transactions are being performed it will have validated the calldata public key and successfully used it. |
CedarMist
force-pushed
the
CedarMist/cdpk_subcall
branch
from
a7cb67b
to
cc01fde
Compare
github-actions bot
added a commit
that referenced
this pull request
Aug 30, 2024
…edarMist/cdpk_subcall contracts: add support for core.CallDataPublicKey and core.CurrentEpoch 1bb637b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two methods to
Subcall.solcoreCallDataPublicKeycoreCurrentEpoch