Automatically throw on 5xx error responses #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lubej
approved these changes
Aug 9, 2024
| useErrorBoundary: (error: any) => { | ||
| // Automatically throw on 5xx errors. Components that want to handle | ||
| // errors should set `useErrorBoundary: false` in their queries. | ||
| return error.response?.status >= 500 |
There was a problem hiding this comment.
Are we sure that every query is covered? In a sense, I see status queries are disabled, which we don't want to crash the app. But could for example one query on account page "crash" the page to show the error boundary?
There was a problem hiding this comment.
Yeah some 5xx failures could hit page-level error boundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are currently throwing
{"msg":"storage error: can't scan into dest[5]: cannot scan NULL into *string"}https://explorer.dev.oasis.io/testnet/sapphire/address/oasis1qp66ryj9caek77kewkxxvjvkzypljhsdgvm5q34d
https://explorer.dev.oasis.io/search?q=8d5a30f1e586dce3ae7839c5f20c846d6d71b27d185adbacd32778d6c60f55eb
but frontend is ignoring the error