Put Networking impls back onto-thread #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eceiver calls to put execution on-thread
|
The client packet change will need more work. the design of the PacketByteBuf read needs a bit of rework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #30
Proposed changes
server.execute()wrapper around impl in theMoreMobVariantscall toregisterGlobalReceiverclient.execute()wrapper around impl in theMoreMobVariantsClientcall toregisterGlobalReceiverReasoning
Networking happens in it's own collection of Netty Event Loop threads, not on the main Render and Server threads. As such, any interaction with Minecraft itself inside networking is off-thread.
execute()queues a task with the server/client to run the code inside it on-thread when it's able.